Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[update] Update preview card #82

Merged
merged 10 commits into from
Apr 12, 2024
Merged

[update] Update preview card #82

merged 10 commits into from
Apr 12, 2024

Conversation

Marcoss28
Copy link
Collaborator

@Marcoss28 Marcoss28 commented Apr 11, 2024

What's new in this PR

  • Preview Card styling updated
  • Preview Card and Content Card emojis/reactions updated

Relevant Links

N/A

Notion Sprint Task

https://www.notion.so/calblueprint/update-Update-preview-card-4b6a8dab0a8949bfb08d289e9fdb179c

Online sources

https://github.com/EricPKerr/react-native-emoji?tab=readme-ov-file

Related PRs

N/A

How to review

  • Run app and check preview card and content card on home screen

Next steps

  • Function that adds story to reading list functionality needs to be implemented
  • Actual reaction/emoji count needs functionality needs to be implemented

Tests Performed, Edge Cases

N/A

Screenshots

IMG_2140
IMG_2141

CC: @adityapawar1

Copy link
Collaborator

@adityapawar1 adityapawar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks amazing! 2 changes b4 we merge

src/components/ContentCard/ContentCard.tsx Outdated Show resolved Hide resolved
src/components/PreviewCard/PreviewCard.tsx Outdated Show resolved Hide resolved
@adityapawar1 adityapawar1 changed the title Marcos/update preview card [update] Update preview card Apr 12, 2024
@adityapawar1 adityapawar1 merged commit 860d346 into main Apr 12, 2024
1 check passed
@adityapawar1 adityapawar1 deleted the marcos/update-preview-card branch April 12, 2024 05:19
jjstnlee pushed a commit that referenced this pull request Apr 15, 2024
* accidently forgot to branch

* [updated preview card]\n[updated preview and content card emojis/reactions]

* chanegs made

* Increase margin by 2

---------

Co-authored-by: Marcos Hernandez <[email protected]>
Co-authored-by: Aditya Pawar <[email protected]>
adityapawar1 added a commit that referenced this pull request Apr 21, 2024
* Created back button component

* Use rpc to check if password is the same (#80)

* Fix worm bug (null tags) (#81)

* Fix worm bug (null tags)

* Run prettier

* Update lint.yml

* Run prettier on lint.yml

* [bug] Add other ethnicities (#83)

* Add other ethnicities

* Remove old settings

* [update] Update preview card (#82)

* accidently forgot to branch

* [updated preview card]\n[updated preview and content card emojis/reactions]

* chanegs made

* Increase margin by 2

---------

Co-authored-by: Marcos Hernandez <[email protected]>
Co-authored-by: Aditya Pawar <[email protected]>

* Created Back Button Component

---------

Co-authored-by: Aditya Pawar <[email protected]>
Co-authored-by: Marcoss28 <[email protected]>
Co-authored-by: Marcos Hernandez <[email protected]>
Co-authored-by: Aditya Pawar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants